pkp/pkp-lib#2612 Submission filtering #2704
Conversation
NateWr
force-pushed
the
i2612_filter_submissions
branch
from
b21da8f
to
2e37b80
Compare
…mplete submissions
NateWr
force-pushed
the
i2612_filter_submissions
branch
from
2e37b80
to
dc1598f
Compare
| @@ -1,12 +1,12 @@ | |||
| <?php | |||
| /** | |||
| * @file controllers/list/submissions/SubmissionsListHandler.inc.php | |||
| * @file controllers/list/submissions/PKPSubmissionsListHandler.inc.php | |||
| * | |||
| * Copyright (c) 2014-2017 Simon Fraser University | |||
| * Copyright (c) 2000-2016 John Willinsky | |||
| * | ||
| * Copyright (c) 2014-2017 Simon Fraser University | ||
| * Copyright (c) 2000-2016 John Willinsky | ||
| * Distributed under the GNU GPL v2. For full terms see the file docs/COPYING. | ||
| * | ||
| * @class SubmissionsListHandler | ||
| * @class PKPSubmissionsListHandler | ||
| * @ingroup classes_controllers_list |
| if (this.isFilterActive(type, val)) { | ||
| this.clearFilter(type, val); | ||
| return; | ||
| } |
There was a problem hiding this comment.
What is happening here: when a filter that is active is added, it will be removed? :-\
There was a problem hiding this comment.
It's a toggle feature. Click once to activate it. If you click on the filter again, you deactivate it.
| // Deactivate the isIncomplete filter when any other filter is selected | ||
| } else if (this.isFilterActive('isIncomplete', true)) { | ||
| this.clearFilter('isIncomplete', true); | ||
| } |
There was a problem hiding this comment.
Does this mean that the isIncomplete filter is always used alone -- it cannot be combined with others? -- Is this because the intersection with other filters does not exist, because it is always "AND" relationship for the results?
There was a problem hiding this comment.
Yeah, isIncomplete filter doesn't play well with the overdue or stage filters, because isIncomplete is always in the Submission stage. But end-users don't really think of incomplete submissions as "in" the submission stage. They see it as a pre-stage.
| * Can the current user filter the list? | ||
| */ | ||
| currentUserCanFilter: function() { | ||
| return pkp.userHasRole(['manager', 'subeditor', 'assistant']); |
There was a problem hiding this comment.
Just curious: where is this function i.e. roles defined?
There was a problem hiding this comment.
js/load.js in OJS/OMP. Eventually we'll probably build the pkp global from an export and can share code between OJS/OMP. But I'm keeping it simple for now.
There was a problem hiding this comment.
Oh and we'll probably use constants for this eventually. See #2708.
No description provided.